Updating instances of Metamask to MetaMask #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
force-pushed
the
update-incorrect-metamask-instances
branch
2 times, most recently
from
d450047
to
dc15dbf
Compare
rickycodes
approved these changes
Jun 6, 2022
georgewrmarshall
force-pushed
the
update-incorrect-metamask-instances
branch
from
dc15dbf
to
91e14de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there are a few instances of "Metamask" in our translations, tests and comments. This is an incorrect casing of "MetaMask"
This is a problem because it degrades our brand and causes confusion on the correct casing for our users and engineers - myself included!
In order to solve this problem, this pull request updates all instances of "Metamask" to "MetaMask" in content, tests and comments. It DOES NOT change any instance of "Metamask" in the code e.g. file name references, controllers, function names etc.
Checklist
[x] There is a related GitHub issueNA[x] Tests are included if applicableNA[x] Any added code is fully documentedNAMore Information
This PR was spurred by @jspence425 slack thread
Equivalent PRs in extension
MetaMask/metamask-extension#14848
MetaMask/metamask-extension#14851
Manual Testing Steps